Thread (87 messages) 87 messages, 5 authors, 2025-06-30

Re: [PATCH RFC 25/29] mm: simplify folio_expected_ref_count()

From: Zi Yan <ziy@nvidia.com>
Date: 2025-06-23 14:23:58
Also in: linux-fsdevel, linux-mm, linuxppc-dev, lkml, virtualization

On 18 Jun 2025, at 13:40, David Hildenbrand wrote:
Now that PAGE_MAPPING_MOVABLE is gone, we can simplify and rely on the
folio_test_anon() test only.

... but staring at the users, this function should never even have been
called on movable_ops pages. E.g.,
* __buffer_migrate_folio() does not make sense for them
* folio_migrate_mapping() does not make sense for them
* migrate_huge_page_move_mapping() does not make sense for them
* __migrate_folio() does not make sense for them
* ... and khugepaged should never stumble over them

Let's simply refuse typed pages (which includes slab) except hugetlb,
and WARN.

Signed-off-by: David Hildenbrand <redacted>
---
 include/linux/mm.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Zi Yan <ziy@nvidia.com>
--
Best Regards,
Yan, Zi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help