On Mon, Jun 16, 2025 at 07:37:26PM -0700, Nicolin Chen wrote:

On Mon, Jun 16, 2025 at 11:13:19AM -0300, Jason Gunthorpe wrote:

quoted

On Sat, Jun 14, 2025 at 12:14:38AM -0700, Nicolin Chen wrote:

quoted

+/* Entry for iommufd_ctx::mt_mmap */
+struct iommufd_mmap {
+	struct iommufd_object *owner;
+
+	/* Allocated start position in mt_mmap tree */
+	unsigned long startp;

pgoff_t, looks like this is already in PAGE_SIZE units.

quoted

+	/* Physical range for io_remap_pfn_range() */
+	unsigned long mmio_pfn;

physaddr_t and maybe don't use pfn?

quoted

+	unsigned long num_pfns;

size_t

The mtree stores in pfn units. Looks like you prefer doing in
PAGE_SIZE units? I can give that a try and update them as you
suggested.

PFN and PAGE_SIZE units are the same thing

Jason