Re: [PATCH v2 15/15] iommupt: Add a kunit test for the IOMMU implementation

On Mon, May 05, 2025 at 02:47:47PM -0300, Jason Gunthorpe wrote:

On Mon, May 05, 2025 at 10:44:58AM -0700, Nathan Chancellor wrote:

quoted

On Mon, May 05, 2025 at 11:18:45AM -0300, Jason Gunthorpe wrote:

quoted

This intends to have high coverage of the page table format functions and
the IOMMU implementation itself, exercising the various corner cases.

The kunit can be run in the kunit framework, using commands like:

tools/testing/kunit/kunit.py run --build_dir build_kunit_arm64 --arch arm64 --make_options LLVM=1 --make_options LLVM_SUFFIX=-19 --kunitconfig ./drivers/iommu/generic_pt/.kunitconfig

Just a small comment about the command:

  --make_options LLVM=1 --make_options LLVM_SUFFIX=-19

can be simplified to just

  --make_options LLVM=-19

You should never need to specify either LLVM_SUFFIX or LLVM_PREFIX.

Oh wow, I had no idea. Can I encourage you to send a patch for 'make
help' to explain how to use it?

I will see if I can come up with something concise for 'make help' but
we have it written up in Documentation/kbuild/llvm.rst:

https://docs.kernel.org/kbuild/llvm.html

Cheers,
Nathan