Re: [PATCH v3 01/15] scsi: pm8001: do not overwrite PCI queue mapping

[PATCH v3 00/15] honor isolcpus configuration · Daniel Wagner <hidden> · 2024-08-06
[PATCH v3 03/15] blk-mq: introduce blk_mq_dev_map_queues · Daniel Wagner <hidden> · 2024-08-06
Re: [PATCH v3 03/15] blk-mq: introduce blk_mq_dev_map_queues · Christoph Hellwig <hch@lst.de> · 2024-08-06
Re: [PATCH v3 03/15] blk-mq: introduce blk_mq_dev_map_queues · Daniel Wagner <hidden> · 2024-08-07
Re: [PATCH v3 03/15] blk-mq: introduce blk_mq_dev_map_queues · Christoph Hellwig <hch@lst.de> · 2024-08-12
[PATCH v3 01/15] scsi: pm8001: do not overwrite PCI queue mapping · Daniel Wagner <hidden> · 2024-08-06
Re: [PATCH v3 01/15] scsi: pm8001: do not overwrite PCI queue mapping · Christoph Hellwig <hch@lst.de> · 2024-08-06
Re: [PATCH v3 01/15] scsi: pm8001: do not overwrite PCI queue mapping · John Garry <john.g.garry@oracle.com> · 2024-08-06
[PATCH v3 04/15] scsi: replace blk_mq_pci_map_queues with blk_mq_dev_map_queues · Daniel Wagner <hidden> · 2024-08-06
Re: [PATCH v3 04/15] scsi: replace blk_mq_pci_map_queues with blk_mq_dev_map_queues · Christoph Hellwig <hch@lst.de> · 2024-08-12
Re: [PATCH v3 04/15] scsi: replace blk_mq_pci_map_queues with blk_mq_dev_map_queues · John Garry <john.g.garry@oracle.com> · 2024-08-12
Re: [PATCH v3 04/15] scsi: replace blk_mq_pci_map_queues with blk_mq_dev_map_queues · Daniel Wagner <hidden> · 2024-08-13
[PATCH v3 02/15] virito: add APIs for retrieving vq affinity · Daniel Wagner <hidden> · 2024-08-06
Re: [PATCH v3 02/15] virito: add APIs for retrieving vq affinity · Christoph Hellwig <hch@lst.de> · 2024-08-06
[PATCH v3 05/15] nvme: replace blk_mq_pci_map_queues with blk_mq_dev_map_queues · Daniel Wagner <hidden> · 2024-08-06
Re: [PATCH v3 05/15] nvme: replace blk_mq_pci_map_queues with blk_mq_dev_map_queues · Christoph Hellwig <hch@lst.de> · 2024-08-12
[PATCH v3 06/15] virtio: blk/scs: replace blk_mq_virtio_map_queues with blk_mq_dev_map_queues · Daniel Wagner <hidden> · 2024-08-06
Re: [PATCH v3 06/15] virtio: blk/scs: replace blk_mq_virtio_map_queues with blk_mq_dev_map_queues · Christoph Hellwig <hch@lst.de> · 2024-08-12
[PATCH v3 07/15] blk-mq: remove unused queue mapping helpers · Daniel Wagner <hidden> · 2024-08-06
Re: [PATCH v3 07/15] blk-mq: remove unused queue mapping helpers · Christoph Hellwig <hch@lst.de> · 2024-08-12
Re: [PATCH v3 07/15] blk-mq: remove unused queue mapping helpers · Daniel Wagner <hidden> · 2024-08-13
[PATCH v3 08/15] sched/isolation: Add io_queue housekeeping option · Daniel Wagner <hidden> · 2024-08-06
[PATCH v3 09/15] docs: add io_queue as isolcpus options · Daniel Wagner <hidden> · 2024-08-06
[PATCH v3 10/15] blk-mq: add number of queue calc helper · Daniel Wagner <hidden> · 2024-08-06
Re: [PATCH v3 10/15] blk-mq: add number of queue calc helper · Christoph Hellwig <hch@lst.de> · 2024-08-12
[PATCH v3 11/15] nvme-pci: use block layer helpers to calculate num of queues · Daniel Wagner <hidden> · 2024-08-06
Re: [PATCH v3 11/15] nvme-pci: use block layer helpers to calculate num of queues · Christoph Hellwig <hch@lst.de> · 2024-08-12
[PATCH v3 12/15] scsi: use block layer helpers to calculate num of queues · Daniel Wagner <hidden> · 2024-08-06
Re: [PATCH v3 12/15] scsi: use block layer helpers to calculate num of queues · Christoph Hellwig <hch@lst.de> · 2024-08-12
[PATCH v3 13/15] virtio: blk/scsi: use block layer helpers to calculate num of queues · Daniel Wagner <hidden> · 2024-08-06
[PATCH v3 14/15] lib/group_cpus.c: honor housekeeping config when grouping CPUs · Daniel Wagner <hidden> · 2024-08-06
Re: [PATCH v3 14/15] lib/group_cpus.c: honor housekeeping config when grouping CPUs · Ming Lei <hidden> · 2024-08-06
Re: [PATCH v3 14/15] lib/group_cpus.c: honor housekeeping config when grouping CPUs · Christoph Hellwig <hch@lst.de> · 2024-08-12
[PATCH v3 15/15] blk-mq: use hk cpus only when isolcpus=io_queue is enabled · Daniel Wagner <hidden> · 2024-08-06
Re: [PATCH v3 15/15] blk-mq: use hk cpus only when isolcpus=io_queue is enabled · Ming Lei <hidden> · 2024-08-06
Re: [PATCH v3 15/15] blk-mq: use hk cpus only when isolcpus=io_queue is enabled · Daniel Wagner <hidden> · 2024-08-07
Re: [PATCH v3 15/15] blk-mq: use hk cpus only when isolcpus=io_queue is enabled · Ming Lei <hidden> · 2024-08-08
Re: [PATCH v3 15/15] blk-mq: use hk cpus only when isolcpus=io_queue is enabled · Daniel Wagner <hidden> · 2024-08-09
Re: [PATCH v3 15/15] blk-mq: use hk cpus only when isolcpus=io_queue is enabled · Ming Lei <hidden> · 2024-08-09
Re: [PATCH v3 15/15] blk-mq: use hk cpus only when isolcpus=io_queue is enabled · Ming Lei <hidden> · 2024-08-09
Re: [PATCH v3 15/15] blk-mq: use hk cpus only when isolcpus=io_queue is enabled · Daniel Wagner <hidden> · 2024-08-13
Re: [PATCH v3 15/15] blk-mq: use hk cpus only when isolcpus=io_queue is enabled · Ming Lei <hidden> · 2024-08-13
Re: [PATCH v3 15/15] blk-mq: use hk cpus only when isolcpus=io_queue is enabled · Daniel Wagner <hidden> · 2024-08-13
Re: [PATCH v3 00/15] honor isolcpus configuration · Stefan Hajnoczi <hidden> · 2024-08-06
Re: [PATCH v3 00/15] honor isolcpus configuration · Daniel Wagner <hidden> · 2024-08-07

From: Christoph Hellwig <hch@lst.de>
Date: 2024-08-06 13:24:46
Also in: linux-block, linux-nvme, linux-scsi, lkml, virtualization

On Tue, Aug 06, 2024 at 02:06:33PM +0200, Daniel Wagner wrote:

blk_mq_pci_map_queues maps all queues but right after this, we
overwrite these mappings by calling blk_mq_map_queues. Just use one
helper but not both.

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help