[PATCH v24 27/34] ALSA: usb-audio: qcom: Use card and PCM index from QMI request
flat view
STALE797d
SUPERSEDED
From: Wesley Cheng <hidden>
Date: 2024-08-01 01:18:43
Also in:
alsa-devel, linux-arm-msm, linux-devicetree, linux-sound, linux-usb, lkml
Subsystem:
sound, the rest · Maintainers:
Jaroslav Kysela, Takashi Iwai, Linus Torvalds
Status: Superseded by v38 (posted 2025-04-09). [go to v38]
Revision v24 (36 revisions archived).
Revisions (36)
- v3
- v4 [diff against previous]
- v5 [diff against previous]
- v6 [diff against previous]
- v7 [diff against previous]
- v8 [diff against previous]
- v9 [diff against previous]
- v10 [diff against previous]
- v11 [diff against previous]
- v12 [diff against previous]
- v13 [diff against previous]
- v14 [diff against previous]
- v15 [diff against previous]
- v16 [diff against previous]
- v17 [diff against previous]
- v18 [diff against previous]
- v19 [diff against previous]
- v20 [diff against previous]
- v21 [diff against previous]
- v22 [diff against previous]
- v23 [diff against previous]
- v24 current [diff against previous]
- v25 [diff against previous]
- v26 [diff against previous]
- v27 [diff against previous]
- v28 [diff against previous] re-posted go to this post re-posted go to this post
- v29 [diff against previous]
- v30 [diff against previous]
- v31 [diff against previous]
- v32 [diff against previous]
- v33 [diff against previous]
- v34 [diff against previous]
- v35 [diff against previous]
- v36 [diff against previous]
- v37 [diff against previous]
- v38 [diff against previous]
Utilize the card and PCM index coming from the USB QMI stream request. This field follows what is set by the ASoC USB backend, and could potentially carry information about a specific device selected through the ASoC USB backend. The backend also has information about the last USB sound device plugged in, so it can choose to select the last device plugged in, accordingly. Signed-off-by: Wesley Cheng <redacted> --- sound/usb/qcom/qc_audio_offload.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/sound/usb/qcom/qc_audio_offload.c b/sound/usb/qcom/qc_audio_offload.c
index 3b46d05f1421..fc7beadfd0f9 100644
--- a/sound/usb/qcom/qc_audio_offload.c
+++ b/sound/usb/qcom/qc_audio_offload.c@@ -106,8 +106,6 @@ struct uaudio_qmi_dev { bool er_mapped; /* reference count to number of possible consumers */ atomic_t qdev_in_use; - /* idx to last udev card number plugged in */ - unsigned int last_card_num; }; struct uaudio_dev {
@@ -1240,7 +1238,7 @@ static int prepare_qmi_response(struct snd_usb_substream *subs, pcm_dev_num = (req_msg->usb_token & QMI_STREAM_REQ_DEV_NUM_MASK) >> 8; xfer_buf_len = req_msg->xfer_buff_size; - card_num = uaudio_qdev->last_card_num; + card_num = (req_msg->usb_token & QMI_STREAM_REQ_CARD_NUM_MASK) >> 16; if (!uadev[card_num].ctrl_intf) { dev_err(&subs->dev->dev, "audio ctrl intf info not cached\n");
@@ -1433,8 +1431,7 @@ static void handle_uaudio_stream_req(struct qmi_handle *handle, direction = (req_msg->usb_token & QMI_STREAM_REQ_DIRECTION); pcm_dev_num = (req_msg->usb_token & QMI_STREAM_REQ_DEV_NUM_MASK) >> 8; - pcm_card_num = req_msg->enable ? uaudio_qdev->last_card_num : - ffs(uaudio_qdev->card_slot) - 1; + pcm_card_num = (req_msg->usb_token & QMI_STREAM_REQ_CARD_NUM_MASK) >> 16; if (pcm_card_num >= SNDRV_CARDS) { ret = -EINVAL; goto response;
@@ -1662,7 +1659,6 @@ static void qc_usb_audio_offload_probe(struct snd_usb_audio *chip) sdev->chip_idx = chip->index; uadev[chip->card->number].sdev = sdev; - uaudio_qdev->last_card_num = chip->card->number; snd_soc_usb_connect(usb_get_usb_backend(udev), sdev); mutex_unlock(&chip->mutex);