Thread (331 messages) 331 messages, 12 authors, 2024-02-13

Re: [PATCH v15-RFC 4/8] x86/resctrl: Add helper function to look up domain_id from scope

From: Tony Luck <tony.luck@intel.com>
Date: 2024-02-09 19:06:06
Also in: linux-patches, lkml

On Fri, Feb 09, 2024 at 09:28:52AM -0600, Moger, Babu wrote:
quoted
+	if (id < 0) {
+		pr_warn_once("Can't find domain id for CPU:%d scope:%d for resource %s\n",
+			     cpu, r->scope, r->name);
Will it be good to move pr_warn_once inside get_domain_id_from_scope
instead of repeating during every call?
Yes. Will move from here to get_domain_id_from_scope().
quoted
+	if (id < 0) {
+		pr_warn_once("Can't find domain id for CPU:%d scope:%d for resource %s\n",
+			     cpu, r->scope, r->name);
Same comment as above. Will it be good to move pr_warn_once inside
get_domain_id_from_scope ?
Moved this one too.

Thanks

-Tony
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help