Re: [PATCH RFC 12/22] drivers: base: Print a warning instead of panic() when register_cpu() fails
From: Shaoqin Huang <hidden>
Date: 2023-11-10 03:36:42
Also in:
kvmarm, linux-acpi, linux-arch, linux-arm-kernel, linux-pm, linux-riscv, lkml, loongarch
On 11/7/23 18:30, Russell King (Oracle) wrote:
From: James Morse <james.morse@arm.com> loongarch, mips, parisc, riscv and sh all print a warning if register_cpu() returns an error. Architectures that use GENERIC_CPU_DEVICES call panic() instead. Errors in this path indicate something is wrong with the firmware description of the platform, but the kernel is able to keep running. Downgrade this to a warning to make it easier to debug this issue. This will allow architectures that switching over to GENERIC_CPU_DEVICES to drop their warning, but keep the existing behaviour. Signed-off-by: James Morse <james.morse@arm.com> Reviewed-by: Russell King (Oracle) <redacted> Signed-off-by: Russell King (Oracle) <redacted>
Reviewed-by: Shaoqin Huang <redacted>
quoted hunk ↗ jump to hunk
--- drivers/base/cpu.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)diff --git a/drivers/base/cpu.c b/drivers/base/cpu.c index 221ffbeb1c9b..82b6a76125f5 100644 --- a/drivers/base/cpu.c +++ b/drivers/base/cpu.c@@ -551,14 +551,15 @@ void __weak arch_unregister_cpu(int num) static void __init cpu_dev_register_generic(void) { - int i; + int i, ret; if (!IS_ENABLED(CONFIG_GENERIC_CPU_DEVICES)) return; for_each_present_cpu(i) { - if (arch_register_cpu(i)) - panic("Failed to register CPU device"); + ret = arch_register_cpu(i); + if (ret) + pr_warn("register_cpu %d failed (%d)\n", i, ret); } }
-- Shaoqin