Re: [PATCH 22/35] arm64/mm: Implement map_shadow_stack()

From
Edgecombe, Rick P <rick.p.edgecombe@intel.com>
Date
2023-07-18 15:49:48
Also in
kvmarm, linux-arch, linux-arm-kernel, linux-fsdevel, linux-kselftest, linux-mm, linux-riscv, lkml
Reply to
Mark Brown, 2023-07-18
On Tue, 2023-07-18 at 14:55 +0100, Mark Brown wrote:
On Tue, Jul 18, 2023 at 10:10:04AM +0100, Szabolcs Nagy wrote:
quoted
   uint64_t *p = map_shadow_stack(0, N*8, 0);
quoted
i'd expect p[N-1] to be the end token and p[N-2] to be the cap
token,
not p[PAGE_ALIGN(N*8)/8-2].
Yes, that probably would be more helpful.
HJ made a similar request on the x86 side. He wanted an unaligned size
passed in to result in unaligned token placement.
quoted
if we allow misalligned size here (and in munmap) then i think it's
better to not page align.  size%8!=0 || size<16 can be an error.
Honestly I'd be a lot happier to just not allow misalignment but that
raises the issue with binaries randomly not working when moved to a
kernel with a different page size.  I'll have a think but possibly
the
safest thing would be requiring a multiple of 4K then rounding up to
our
actual page size.

Someday when the x86 side is finally upstream I have a manpage for
map_shadow_stack. Any differences on the arm side would need to be
documented, but I'm not sure why there should be any differences. Like,
why not use the same flags? Or have a new flag for token+end marker
that x86 can use as well?
Thread (51 messages) 51 messages, 5 authors, last reply 2023-07-19
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help