Re: [PATCH] docs: submitting-patches: Discuss interleaved replies
From: Thorsten Leemhuis <linux@leemhuis.info>
Date: 2023-05-13 09:24:27
Also in:
linux-hardening, lkml
On 11.05.23 20:37, Kees Cook wrote:
On Thu, May 11, 2023 at 11:21:36AM +0200, Thorsten Leemhuis wrote:quoted
On 10.05.23 20:34, Kees Cook wrote:quoted
Top-posting has been strongly discouraged in Linux development, but this was actually not written anywhere in the common documentation about sending patches and replying to reviews. Add a section about trimming and interleaved replies.Thx for doing this.quoted
[...] --- Documentation/process/submitting-patches.rst | 23 ++++++++++++++++++++ 1 file changed, 23 insertions(+)For some reason we have duplicate code^w documentation for this, hence I'd say the same or a similar text should also be added to one of the filed in Documentation/process/[0-9].*rst ; from a quick Documentation/process/6.Followthrough.rst might be the best one. Maybe in fact the text should move there and submitting-patches.rst should have a much shorter version, as it's meant to be the terser of the two docs about this.Hm, The place where it is mentioned is even shorter,
Ohh, it is mentioned there already? I briefly looked, but had missed it. Sorry. :-/
so I kind of like it in submittingpatches. But, I'm open to whatever seems best.
Guess that is Jonathan's call to make. Your v2 patch to me looks a bit like adding quite a bit of new and slow code to the fast path while adjusting faster code in the slow path. But the relation and interaction between those two texts in a bit messy already, so maybe it doesn't matter that much. Ciao, Thorsten