Re: [PATCH v7 net-next 2/8] sfc: add devlink info support for ef100

On 14/02/2023 07:39, Leon Romanovsky wrote:

On Mon, Feb 13, 2023 at 06:34:22PM +0000, alejandro.lucero-palau@amd.com wrote:

quoted

+#ifdef CONFIG_RTC_LIB
+	u64 tstamp;
+#endif

If you are going to resubmit the series.

Documentation/process/coding-style.rst
  1140 21) Conditional Compilation
  1141 ---------------------------
....
  1156 If you have a function or variable which may potentially go unused in a
  1157 particular configuration, and the compiler would warn about its definition
  1158 going unused, mark the definition as __maybe_unused rather than wrapping it in
  1159 a preprocessor conditional.  (However, if a function or variable *always* goes
  1160 unused, delete it.)

Thanks

FWIW, the existing code in sfc all uses the preprocessor
 conditional approach; maybe it's better to be consistent
 within the driver?