Re: [PATCH v1 2/2] leds: add aw20xx driver
From: Pavel Machek <hidden>
Date: 2022-12-07 19:48:24
Also in:
linux-devicetree, linux-leds, lkml
On Mon 2022-11-28 17:45:22, Martin Kurbanov wrote:
On 25.11.2022 11:19, Krzysztof Kozlowski wrote:quoted
quoted
+ $ ls -l /sys/bus/i2c/devices/xxxx/pattern0/ + -rw-r--r-- 1 root root 4096 Jan 1 00:00 clear_leds + -rw-r--r-- 1 root root 4096 Jan 1 00:00 fall_time + -rw-r--r-- 1 root root 4096 Jan 1 00:00 loop_begin + -rw-r--r-- 1 root root 4096 Jan 1 00:00 loop_end_on + -rw-r--r-- 1 root root 4096 Jan 1 00:00 max_breathing_level + -rw-r--r-- 1 root root 4096 Jan 1 00:00 min_breathing_level + -rw-r--r-- 1 root root 4096 Jan 1 00:00 mode + -rw-r--r-- 1 root root 4096 Jan 1 00:00 off_time + -rw-r--r-- 1 root root 4096 Jan 1 00:00 on_time + -rw-r--r-- 1 root root 4096 Jan 1 00:00 ramp + -rw-r--r-- 1 root root 4096 Jan 1 00:00 repeat + -rw-r--r-- 1 root root 4096 Jan 1 00:00 rise_time + -r--r--r-- 1 root root 4096 Jan 1 00:00 running + -rw-r--r-- 1 root root 4096 Jan 1 00:00 select_leds + -rw-r--r-- 1 root root 4096 Jan 1 00:00 start + -rw-r--r-- 1 root root 4096 Jan 1 00:00 togglesysfs documentation goes to Documentation/ABI/Should I add it to Documentation/ABI/testing/sysfs-class-led-driver-aw200xx? Is my understanding correct? Is KernelVersion parameter required?
You really should take a look at pattern trigger. You should probably use same API as it does, perhaps documenting which patterns this particular driver can do in hardware. Best regards, Pavel -- People of Russia, stop Putin before his war on Ukraine escalates.
Attachments
- signature.asc [application/pgp-signature] 195 bytes