Re: [PATCH v2 09/10] sched/psi: per-cgroup PSI stats disable/re-enable interface
From: Chengming Zhou <hidden>
Date: 2022-08-10 01:31:45
Also in:
cgroups, lkml
From: Chengming Zhou <hidden>
Date: 2022-08-10 01:31:45
Also in:
cgroups, lkml
On 2022/8/10 08:39, Chengming Zhou wrote:
On 2022/8/10 01:48, Tejun Heo wrote:quoted
Hello, On Mon, Aug 08, 2022 at 07:03:40PM +0800, Chengming Zhou wrote:quoted
So this patch introduce a per-cgroup PSI stats disable/re-enable interface "cgroup.psi", which is a read-write single value file that allowed values are "0" and "1", the defaults is "1" so per-cgroup PSI stats is enabled by default.Given that the knobs are named {cpu|memory|io}.pressure, I wonder whether "cgroup.psi" is the best name. Also, it doesn't convey that it's the enable/disable knob. I think it needs a better name.Yes, "cgroup.psi" is not good. What abort "pressure.enable" or "cgroup.psi_enable"?
Doesn't look good either, what do you think of "cgroup.pressure.enable"? Thanks.