Thread (18 messages) 18 messages, 2 authors, 2021-12-09

Re: [PATCH 04/11] docs/vm: delele three spaces from page_owner

flat view

From: yanteng si <hidden>
Date: 2021-12-09 07:17:13

Jonathan Corbet [off-list ref] 于2021年12月7日周二 01:58写道:
Yanteng Si [off-list ref] writes:
quoted
Fix warning as:

linux-next/Documentation/vm/page_owner.rst:92: WARNING: Unexpected indentation.
linux-next/Documentation/vm/page_owner.rst:96: WARNING: Unexpected indentation.
linux-next/Documentation/vm/page_owner.rst:107: WARNING: Unexpected indentation.
A general comment: "fixed a warning" is almost never a useful changelog
entry.  Instead, talk about what you fixed that was causing the warning;
that, not the warning itself, is the real problem.
OK! get it.
quoted
Signed-off-by: Yanteng Si <redacted>
---
 Documentation/vm/page_owner.rst | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/vm/page_owner.rst b/Documentation/vm/page_owner.rst
index 9837fc8147dd..9a3af6aafa09 100644
--- a/Documentation/vm/page_owner.rst
+++ b/Documentation/vm/page_owner.rst
@@ -89,11 +89,11 @@ Usage

      Page allocated via order XXX, ...
      PFN XXX ...
-      // Detailed stack
+     // Detailed stack

      Page allocated via order XXX, ...
      PFN XXX ...
-      // Detailed stack
+     // Detailed stack
I don't think this is the right fix; instead, this text should be in a
literal block.
OK, Thanks!

Thanks,
Yanteng
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help