[PATCH v18 12/17] kdump: Reduce unused parameters of parse_crashkernel_{high|low}
From: Zhen Lei <hidden>
Date: 2021-12-22 13:13:01
Also in:
kexec, linux-arm-kernel, linux-devicetree, lkml
Subsystem:
kdump, the rest · Maintainers:
Andrew Morton, Baoquan He, Mike Rapoport, Pasha Tatashin, Pratyush Yadav, Linus Torvalds
The parameters 'system_ram' and 'crash_base' is only needed by the case of "crashkernel=X@[offset]". The argument list of parse_crashkernel_suffix() can help prove this point. Signed-off-by: Zhen Lei <redacted> --- kernel/crash_core.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/kernel/crash_core.c b/kernel/crash_core.c
index a037076b89a9bb2..67f5065e3c3cfcc 100644
--- a/kernel/crash_core.c
+++ b/kernel/crash_core.c@@ -288,19 +288,19 @@ int __init parse_crashkernel(char *cmdline, #ifdef CONFIG_64BIT static int __init parse_crashkernel_high(char *cmdline, - unsigned long long system_ram, - unsigned long long *crash_size, - unsigned long long *crash_base) + unsigned long long *crash_size) { - return __parse_crashkernel(cmdline, system_ram, crash_size, crash_base, SUFFIX_HIGH); + unsigned long long base; + + return __parse_crashkernel(cmdline, 0, crash_size, &base, SUFFIX_HIGH); } static int __init parse_crashkernel_low(char *cmdline, - unsigned long long system_ram, - unsigned long long *crash_size, - unsigned long long *crash_base) + unsigned long long *crash_size) { - return __parse_crashkernel(cmdline, system_ram, crash_size, crash_base, SUFFIX_LOW); + unsigned long long base; + + return __parse_crashkernel(cmdline, 0, crash_size, &base, SUFFIX_LOW); } static int __init reserve_crashkernel_low(unsigned long long low_size)
@@ -368,14 +368,14 @@ static int __init parse_crashkernel_in_order(char *cmdline, #ifdef CONFIG_64BIT /* crashkernel=X,high */ - ret = parse_crashkernel_high(cmdline, system_ram, crash_size, crash_base); + ret = parse_crashkernel_high(cmdline, crash_size); if (ret || crash_size <= 0) return CRASHKERNEL_MEM_NONE; flag = CRASHKERNEL_MEM_HIGH; /* crashkernel=Y,low */ - ret = parse_crashkernel_low(cmdline, system_ram, low_size, crash_base); + ret = parse_crashkernel_low(cmdline, low_size); if (!ret) flag |= CRASHKERNEL_MEM_LOW; #endif
--
2.25.1