Re: [PATCH v2 23/23] objtool, kcsan: Remove memory barrier instrumentation from noinstr

From
Josh Poimboeuf <hidden>
Date
2021-11-24 17:53:20
Also in
linux-arch, linux-kbuild, linux-mm, lkml
Reply to
Marco Elver, 2021-11-23
On Tue, Nov 23, 2021 at 12:29:39PM +0100, Marco Elver wrote:
On Fri, Nov 19, 2021 at 12:31PM -0800, Josh Poimboeuf wrote:
quoted
On Thu, Nov 18, 2021 at 09:10:27AM +0100, Marco Elver wrote:
[...]
quoted
quoted
+	if (insn->sec->noinstr && sym->removable_instr) {
[...]
quoted
I'd love to have a clearer name than 'removable_instr', though I'm
having trouble coming up with something.
[...]

I now have the below as v3 of this patch. The naming isn't entirely
obvious, but coming up with a short name for this is tricky, but
hopefully the comments make it clear. We can of course still pick
another name.

Does that look reasonable?

Note, I'd like this series to sit in -next for a while (probably from
some time next week after sending v3 if there are no further
complaints). By default everything will be picked up by the -rcu tree,
and we're targeting Linux 5.18.

If you feel there might be objtool conflicts coming, this patch could be
taken through another tree as there are no hard dependencies, as long as
this patch reaches mainline before or with the rest.

Thanks,
-- Marco
Looks good to me.  I don't know of any upcoming conflicts, feel free to
carry it with your series for now.

Acked-by: Josh Poimboeuf <redacted>

-- 
Josh
Thread (34 messages) 34 messages, 4 authors, last reply 2021-11-29
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help