Thread (32 messages) 32 messages, 5 authors, 2021-11-03

Re: [RFC v2 10/11] hte: Add tegra GPIO HTE test driver

From: Dipen Patel <dipenp@nvidia.com>
Date: 2021-11-03 05:06:40
Also in: linux-devicetree, linux-gpio, linux-tegra, lkml

Hi,


On 10/1/21 4:47 PM, Randy Dunlap wrote:
Hi,

On 9/30/21 4:26 PM, Dipen Patel wrote:
quoted
diff --git a/drivers/hte/Kconfig b/drivers/hte/Kconfig
index eb339526f141..57c97034d187 100644
--- a/drivers/hte/Kconfig
+++ b/drivers/hte/Kconfig
@@ -38,4 +38,13 @@ config HTE_TEGRA194_IRQ_TEST
        The NVIDIA Tegra194 GTE IRQ test driver demonstrates HTE subsystem
        usage for the LIC IRQ hardware timestamp.
  +config HTE_TEGRA194_GPIO_TEST
+        tristate "NVIDIA Tegra194 HTE GPIO Test"
+        depends on HTE_TEGRA194
+        help
+      The NVIDIA Tegra194 GTE GPIO test driver demonstrates how to use HTE
                                                                to use the HTE
quoted
+      subsystem indirectly through gpiolib API calls for GPIO line for the
                                                              lines
quoted
+      hardware assisted timestamping.
      hardware-assisted
quoted
+
  endif
Also:

Please follow coding-style for Kconfig files:

(from Documentation/process/coding-style.rst, section 10):

For all of the Kconfig* configuration files throughout the source tree,
the indentation is somewhat different.  Lines under a ``config`` definition
are indented with one tab, while help text is indented an additional two
spaces.

Some of the lines above are indented with spaces instead of one tab.
I will double check this. From the RFCv1 comments, I did correct formatting according

to above coding style i.e. everything 1 tab except help which is 1 tab + 2 spaces.
thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help