Re: [PATCH v4 1/2] hwmon: (asus_wmi_ec_sensors) Support B550 Asus WMI.
From: kernel test robot <hidden>
Date: 2021-10-11 02:05:04
Also in:
linux-hwmon, oe-kbuild-all, platform-driver-x86
Hi Denis, I love your patch! Yet something to improve: [auto build test ERROR on 39b483aa38995329326988cbc4077422bebc175a] url: https://github.com/0day-ci/linux/commits/Denis-Pauk/Update-ASUS-WMI-supported-boards/20211011-050740 base: 39b483aa38995329326988cbc4077422bebc175a config: ia64-randconfig-r025-20211011 (attached as .config) compiler: ia64-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/4ac420ec20a4c088ebd178ab3d4a345de53b91a2 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Denis-Pauk/Update-ASUS-WMI-supported-boards/20211011-050740 git checkout 4ac420ec20a4c088ebd178ab3d4a345de53b91a2 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=ia64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <redacted> All errors (new ones prefixed by >>): drivers/hwmon/asus_wmi_ec_sensors.c: In function 'asus_wmi_ec_block_read':
quoted
drivers/hwmon/asus_wmi_ec_sensors.c:356:18: error: implicit declaration of function 'wmi_evaluate_method'; did you mean 'wmidev_evaluate_method'? [-Werror=implicit-function-declaration]
356 | status = wmi_evaluate_method(ASUSWMI_MONITORING_GUID, 0, method_id, &input,
| ^~~~~~~~~~~~~~~~~~~
| wmidev_evaluate_method
cc1: some warnings being treated as errors
vim +356 drivers/hwmon/asus_wmi_ec_sensors.c
344
345 static int asus_wmi_ec_block_read(u32 method_id, char *query, u8 *out)
346 {
347 struct acpi_buffer output = { ACPI_ALLOCATE_BUFFER,
348 NULL };
349 struct acpi_buffer input;
350 union acpi_object *obj;
351 acpi_status status;
352
353 /* the first byte of the BRxx() argument string has to be the string size */
354 input.length = (acpi_size)query[0] + 2;
355 input.pointer = query;
> 356 status = wmi_evaluate_method(ASUSWMI_MONITORING_GUID, 0, method_id, &input,
357 &output);
358 if (ACPI_FAILURE(status))
359 return -EIO;
360
361 obj = output.pointer;
362 if (!obj || obj->type != ACPI_TYPE_BUFFER) {
363 if (!obj)
364 acpi_os_free(output.pointer);
365
366 return -EIO;
367 }
368 asus_wmi_ec_decode_reply_buffer(obj->buffer.pointer, out);
369 acpi_os_free(output.pointer);
370 return 0;
371 }
372
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Attachments
- .config.gz [application/gzip] 30584 bytes