On Fri, Oct 29, 2021 at 1:25 PM Steven Rostedt [off-list ref] wrote:

On Fri, 29 Oct 2021 11:53:16 -0700
Kalesh Singh [off-list ref] wrote:

quoted

quoted

If these functions are only called when val2 is constant, can't we make it
such that we get val2 from the hist_field directly? That is:

        u64 val2 = operand2->constant;

operand2 might be a var ref to a constant, so we would need to resolve
that with hist_field_var_ref().

So can a var_ref change? If not, then we should convert that to a constant
for this operation.

A var ref to a constant won't change. I think we can just copy the
constant value to the var ref's hist field and then we'll be able to
get it from there instead of calling the fn() function. I'll post
another version with this.

Thanks,
Kalesh

-- Steve