Re: [PATCH 4/4] MAINTAINERS: Add git tree and missing files for KPROBES
From: Steven Rostedt <rostedt@goodmis.org>
Date: 2021-10-25 14:49:17
Also in:
lkml
On Mon, 25 Oct 2021 16:31:07 +0800 Tiezhu Yang [off-list ref] wrote:
On 10/25/2021 02:38 PM, Masami Hiramatsu wrote:quoted
On Mon, 25 Oct 2021 11:31:00 +0800 Tiezhu Yang [off-list ref] wrote:quoted
There is no git tree for KPROBES in MAINTAINERS, it is not convinent to rebase, lib/test_kprobes.c and samples/kprobes belong to kprobe, add them. Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn> --- MAINTAINERS | 3 +++ 1 file changed, 3 insertions(+)diff --git a/MAINTAINERS b/MAINTAINERS index 4372473..0e9bc60 100644 --- a/MAINTAINERS +++ b/MAINTAINERS@@ -10506,10 +10506,13 @@ M: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com> M: "David S. Miller" <davem@davemloft.net> M: Masami Hiramatsu <mhiramat@kernel.org> S: Maintained +T: git git://git.kernel.org/pub/scm/linux/kernel/git/mhiramat/linux.gitNACK. As I said, this branch was prepared when I discussed with tip maintainer on kretprobe stackfix series but now it has been maintained on Steve's tracing tree. Steve, should we put your tree here?
I'm fine if kprobes goes through my tree.
quoted hunk ↗ jump to hunk
If yes, should I update patch #4 and then send a v2 version of this patch set?@@ -10505,11 +10505,16 @@ M: Naveen N. Rao <naveen.n.rao@linux.ibm.com> M: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com> M: "David S. Miller" <davem@davemloft.net> M: Masami Hiramatsu <mhiramat@kernel.org> +L: linux-trace-devel@vger.kernel.org
Please do not add the above mailing list. That's more for tracing tools like trace-cmd, kernelshark and the libtracefs/libtraceevent libraries. Only API changes (additions) should go to that list. Not internal updates.
S: Maintained +Q: https://patchwork.kernel.org/project/linux-trace-devel/list/
And this too is for the tracing tools, not the kernel. The patches status on that patchwork do not get updated by changes to the kernel. Only changes to the libraries and tool git trees will update those patches.
quoted hunk ↗ jump to hunk
+T: git git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git F: Documentation/trace/kprobes.rst F: include/asm-generic/kprobes.h F: include/linux/kprobes.h F: kernel/kprobes.c +F: lib/test_kprobes.c +F: samples/kprobes By the way, it seems that we should also update the TRACING git tree [1]? If yes, should I send the following change as a new patch #5 in the v2 version or do the following change in the above patch #4?@@ -19065,8 +19070,10 @@ F: drivers/char/tpm/ TRACING M: Steven Rostedt <rostedt@goodmis.org> M: Ingo Molnar <mingo@redhat.com> +L: linux-trace-devel@vger.kernel.org
Again, don't add that list.
S: Maintained -T: git git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git perf/core +Q: https://patchwork.kernel.org/project/linux-trace-devel/list/
Nor the patchwork.
+T: git git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git F: Documentation/trace/ftrace.rst F: arch/*/*/*/ftrace.h F: arch/*/kernel/ftrace.c
-- Steve