[PATCH 0/2] Docs: usb: update struct usb_driver, remove :c:func:

STALE1779d

4 messages, 2 authors, 2021-10-25 · open the first message on its own page

[PATCH 0/2] Docs: usb: update struct usb_driver, remove :c:func:

From: Philipp Hortmann <hidden>
Date: 2021-10-25 05:09:45

update struct usb_driver and remove :c:func: for usb_register and usb_deregister

Philipp Hortmann (2):
  Docs: usb: update struct usb_driver
  Docs: usb: remove :c:func: for usb_register and usb_deregister

 Documentation/driver-api/usb/writing_usb_driver.rst | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

-- 
2.25.1

[PATCH 1/2] Docs: usb: update struct usb_driver

From: Philipp Hortmann <hidden>
Date: 2021-10-25 05:09:54

update struct usb_driver from usb-skeleton.c.

Signed-off-by: Philipp Hortmann <redacted>
---
 Documentation/driver-api/usb/writing_usb_driver.rst | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/Documentation/driver-api/usb/writing_usb_driver.rst b/Documentation/driver-api/usb/writing_usb_driver.rst
index 2176297e5765..a511c6fecf96 100644
--- a/Documentation/driver-api/usb/writing_usb_driver.rst
+++ b/Documentation/driver-api/usb/writing_usb_driver.rst
@@ -57,9 +57,12 @@ structure. The skeleton driver declares a :c:type:`usb_driver` as::
 	    .name        = "skeleton",
 	    .probe       = skel_probe,
 	    .disconnect  = skel_disconnect,
-	    .fops        = &skel_fops,
-	    .minor       = USB_SKEL_MINOR_BASE,
+	    .suspend     = skel_suspend,
+	    .resume      = skel_resume,
+	    .pre_reset   = skel_pre_reset,
+	    .post_reset  = skel_post_reset,
 	    .id_table    = skel_table,
+	    .supports_autosuspend = 1,
     };
 
 
-- 
2.25.1

[PATCH 2/2] Docs: usb: remove :c:func: for usb_register and usb_deregister

From: Philipp Hortmann <hidden>
Date: 2021-10-25 05:10:01

remove :c:func: for usb_register and usb_deregister

Signed-off-by: Philipp Hortmann <redacted>
---
 Documentation/driver-api/usb/writing_usb_driver.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/driver-api/usb/writing_usb_driver.rst b/Documentation/driver-api/usb/writing_usb_driver.rst
index a511c6fecf96..e09dac9e2cb6 100644
--- a/Documentation/driver-api/usb/writing_usb_driver.rst
+++ b/Documentation/driver-api/usb/writing_usb_driver.rst
@@ -84,7 +84,7 @@ this user-space interaction. The skeleton driver needs this kind of
 interface, so it provides a minor starting number and a pointer to its
 :c:type:`file_operations` functions.
 
-The USB driver is then registered with a call to :c:func:`usb_register`,
+The USB driver is then registered with a call to usb_register(),
 usually in the driver's init function, as shown here::
 
     static int __init usb_skel_init(void)
@@ -105,7 +105,7 @@ usually in the driver's init function, as shown here::
 
 
 When the driver is unloaded from the system, it needs to deregister
-itself with the USB subsystem. This is done with the :c:func:`usb_deregister`
+itself with the USB subsystem. This is done with usb_deregister()
 function::
 
     static void __exit usb_skel_exit(void)
-- 
2.25.1

Re: [PATCH 0/2] Docs: usb: update struct usb_driver, remove :c:func:

From: Greg KH <gregkh@linuxfoundation.org>
Date: 2021-10-25 05:17:25

On Mon, Oct 25, 2021 at 07:09:38AM +0200, Philipp Hortmann wrote:
update struct usb_driver and remove :c:func: for usb_register and usb_deregister

Philipp Hortmann (2):
  Docs: usb: update struct usb_driver
  Docs: usb: remove :c:func: for usb_register and usb_deregister

 Documentation/driver-api/usb/writing_usb_driver.rst | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)
Thanks, these look much better.  I will take them through my usb tree.

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help