Thread (10 messages) 10 messages, 5 authors, 2021-10-14

Re: [PATCH v6 1/2] hwmon: (asus_wmi_ec_sensors) Support B550 Asus WMI.

From: Guenter Roeck <linux@roeck-us.net>
Date: 2021-10-14 14:25:35
Also in: linux-hwmon, lkml, platform-driver-x86

On 10/14/21 5:08 AM, Eugene Shalygin wrote:
quoted
+struct asus_wmi_ec_sensor_address {
+       u8 index;
+       u8 bank;
+       u8 size;
+};
The fourth field which you removed was supposed to hold the data
encoding type, and together those four were packing nicely in u32...
The compiler aligns the data nicely anyway (it will just leave
a 1-byte hole where needed), so the packing is really irrelevant.
Apart of that, does the above suggest that some information/
code is now missing from the driver ?

Guenter
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help