Re: [PATCH v2 4/4] bpf: export bpf_jit_current

On Tue, 12 Oct 2021 at 17:29, Nicolas Dichtel [off-list ref] wrote:

Le 12/10/2021 à 15:59, Lorenz Bauer a écrit :

quoted

Expose bpf_jit_current as a read only value via sysctl.

Signed-off-by: Lorenz Bauer <redacted>
---

[snip]

quoted

+     {
+             .procname       = "bpf_jit_current",
+             .data           = &bpf_jit_current,
+             .maxlen         = sizeof(long),
+             .mode           = 0400,

Why not 0444 ?

This mirrors what the other BPF related sysctls do, which only allow
access from root with CAP_SYS_ADMIN. I'd prefer 0444 as well, but
Daniel explicitly locked down these sysctls in
2e4a30983b0f9b19b59e38bbf7427d7fdd480d98.

Lorenz

--
Lorenz Bauer  |  Systems Engineer
6th Floor, County Hall/The Riverside Building, SE1 7PB, UK

www.cloudflare.com