Thread (40 messages) 40 messages, 7 authors, 2021-10-01

Re: [PATCH v3 16/30] ABI: sysfs-bus-soundwire-slave: use wildcards on What definitions

From: Vinod Koul <vkoul@kernel.org>
Date: 2021-10-01 04:38:00
Also in: lkml

On 16-09-21, 18:47, Mauro Carvalho Chehab wrote:
Hi Pierre,

Em Thu, 16 Sep 2021 11:36:33 -0500
Pierre-Louis Bossart [off-list ref] escreveu:
quoted
On 9/16/21 3:59 AM, Mauro Carvalho Chehab wrote:
quoted
An "N" upper letter is not a wildcard, nor can easily be identified
by script, specially since the USB sysfs define things like.
bNumInterfaces. Use, instead, <N>, in order to let script/get_abi.pl
to convert it into a Regex.

Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>  
Reviewed-by: Pierre-Louis Bossart <redacted>
Thanks!
quoted
I also realized that we have a similar with the 'master' case

more sysfs-bus-soundwire-master
What:		/sys/bus/soundwire/devices/sdw-master-N/revision
		/sys/bus/soundwire/devices/sdw-master-N/clk_stop_modes
		/sys/bus/soundwire/devices/sdw-master-N/clk_freq
		/sys/bus/soundwire/devices/sdw-master-N/clk_gears
		/sys/bus/soundwire/devices/sdw-master-N/default_col
		/sys/bus/soundwire/devices/sdw-master-N/default_frame_rate
		/sys/bus/soundwire/devices/sdw-master-N/default_row
		/sys/bus/soundwire/devices/sdw-master-N/dynamic_shape
		/sys/bus/soundwire/devices/sdw-master-N/err_threshold
		/sys/bus/soundwire/devices/sdw-master-N/max_clk_freq

If there is an update we should modify this as well for consistency with
sdw-master-<N>?
It is on patch 15/30:

	https://lkml.org/lkml/2021/9/16/198
 we should have been cced :(

Thanks to b4, I was able to grab this and apply as well

-- 
~Vinod
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help