Re: [PATCH v8 2/3] mm: add a field to store names for private anonymous memory

On Fri 27-08-21 12:18:57, Suren Baghdasaryan wrote:
[...]

+static void replace_vma_anon_name(struct vm_area_struct *vma, const char *name)
+{
+	if (!name) {
+		free_vma_anon_name(vma);
+		return;
+	}
+
+	if (vma->anon_name) {
+		/* Should never happen, to dup use dup_vma_anon_name() */
+		WARN_ON(vma->anon_name == name);

What is the point of this warning?

+
+		/* Same name, nothing to do here */
+		if (!strcmp(name, vma->anon_name))
+			return;
+
+		free_vma_anon_name(vma);
+	}
+	vma->anon_name = kstrdup(name, GFP_KERNEL);
+}

-- 
Michal Hocko
SUSE Labs