Re: [v3 01/10] RISC-V: Remove the current perf implementation
From: Nikita Shubin <nikita.shubin@maquefel.me>
Date: 2021-09-22 05:25:56
Also in:
linux-devicetree, linux-perf-users, linux-riscv, lkml
Possibly related (same subject, not in this thread)
- 2021-09-10 · [v3 01/10] RISC-V: Remove the current perf implementation · Atish Patra <hidden>
On Wed, 22 Sep 2021 08:11:44 +0300 nikita.shubin@maquefel.me wrote:
Hello Atish. 10.09.2021, 22:28, "Atish Patra" [off-list ref]:quoted
The current perf implementation in RISC-V is not very useful as it can not count any events other than cycle/instructions. Moreover, perf record can not be used or the events can not be started or stopped. Remove the implementation now for a better platform driver in future that will implement most of the missing functionality.Your v3 version still breaks the build with CONFIG_BPF_SYSCALL enabled: kernel/events/core.c: In function 'bpf_overflow_handler': kernel/events/core.c:9914:18: error: assignment to 'bpf_user_pt_regs_t *' {aka 'struct user_regs_struct *'} from incompatible pointer type 'struct pt_regs *' [-Werror=incompatible-pointer-types] 9914 | ctx.regs = perf_arch_bpf_user_pt_regs(regs); | ^
Sorry for the noise. Everything complies fine - i mistaken and applied older version again.
Yours, Nikita Shubin.