Re: [PATCH v2 16/29] ABI: sysfs-bus-soundwire-slave: use wildcards on What definitions
From: Pierre-Louis Bossart <hidden>
Date: 2021-09-14 15:34:15
Also in:
lkml
On 9/14/21 9:32 AM, Mauro Carvalho Chehab wrote:
An "N" upper letter is not a wildcard, nor can easily be identified by script, specially since the USB sysfs define things like. bNumInterfaces. Use, instead, <N>, in order to let script/get_abi.pl to convert it into a Regex.
No objection on the convention but shouldn't that convention be applied to all attributes?
quoted hunk ↗ jump to hunk
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> --- Documentation/ABI/testing/sysfs-bus-soundwire-slave | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/Documentation/ABI/testing/sysfs-bus-soundwire-slave b/Documentation/ABI/testing/sysfs-bus-soundwire-slave index d324aa0b678f..db6b8ffa753e 100644 --- a/Documentation/ABI/testing/sysfs-bus-soundwire-slave +++ b/Documentation/ABI/testing/sysfs-bus-soundwire-slave@@ -64,7 +64,7 @@ Description: SoundWire Slave Data Port-0 DisCo properties. Data port 0 are used by the bus to configure the Data Port 0. -What: /sys/bus/soundwire/devices/sdw:.../dpN_src/max_word +What: /sys/bus/soundwire/devices/sdw:.../dp<N>_src/max_word /sys/bus/soundwire/devices/sdw:.../dpN_src/min_word /sys/bus/soundwire/devices/sdw:.../dpN_src/words /sys/bus/soundwire/devices/sdw:.../dpN_src/type
if we change max_word, shouldn't we change all the others as well?