Re: [PATCH v2] docs: sphinx-requirements: Move sphinx_rtd_theme to top
From: Jonathan Corbet <corbet@lwn.net>
Date: 2021-08-12 15:16:28
Also in:
lkml
From: Jonathan Corbet <corbet@lwn.net>
Date: 2021-08-12 15:16:28
Also in:
lkml
Akira Yokosawa [off-list ref] writes:
sphinx_rtd_theme 0.5.2 has "docutils<0.17" in its requirements. docutils 0.17 released this April caused regression in sphinx_rtd_theme 0.5.1 [1]. By removing docutils and moving sphinx_rtd_theme before Sphinx in requirements.txt, the requirement of "docutils<0.17" can be met naturally. [1]: https://github.com/readthedocs/sphinx_rtd_theme/issues/1112 Signed-off-by: Akira Yokosawa <akiyks@gmail.com> Cc: Mauro Carvalho Chehab <mchehab@kernel.org> --- Hi, It is better to keep requirements as minimal as possible. Let's leave the dependency to the sphinx_rtd_theme package. Changes in v1 [2] -> v2: o Remove docutils entry. o Move sphinx_rtd_theme to top. o Adjust patch title. [2]: https://lore.kernel.org/linux-doc/974babfe-540f-40e4-38b3-ab294ba70ccc@gmail.com/ (local)
Applied, thanks. jon