Thread (25 messages) 25 messages, 4 authors, 2021-08-05

Re: [PATCH v3 04/14] vfio: Provide better generic support for open/release vfio_device_ops

From: Christoph Hellwig <hch@lst.de>
Date: 2021-07-29 07:26:16
Also in: intel-gfx, kvm, linux-s390

+	device->open_count++;
+	if (device->open_count == 1 && device->ops->open_device) {
I would have written this as

	if (++device->open_count == 1 && device->ops->open_device) {

to make the pattern more clear, but that is just a minor nitpick.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help