Re: [PATCH 12/12] vfio/pci: Introduce vfio_pci_core.ko
From: Jason Gunthorpe <jgg@nvidia.com>
Date: 2021-07-28 12:48:01
Also in:
kvm, linux-kbuild, linux-pci, linux-s390
Subsystem:
the rest, vfio driver · Maintainers:
Linus Torvalds, Alex Williamson
On Wed, Jul 28, 2021 at 02:29:56PM +0200, Christoph Hellwig wrote:
So not really an issue here. VFIO_PCI_CORE really is underlying infrastructure a user should not care about.
So then we can write it like below? Unfortunately it deletes the nice menu structure that groups all the PCI drivers together like platform (and mdev in future). Not sure this loss is worth the backwards compat
diff --git a/drivers/vfio/pci/Kconfig b/drivers/vfio/pci/Kconfig
index 318116d03c21a4..2611d7d91ddbd5 100644
--- a/drivers/vfio/pci/Kconfig
+++ b/drivers/vfio/pci/Kconfig@@ -1,14 +1,12 @@ # SPDX-License-Identifier: GPL-2.0-only +if PCI || MMU config VFIO_PCI_CORE - tristate "VFIO support for PCI devices" - depends on PCI - depends on MMU + tristate select VFIO_VIRQFD select IRQ_BYPASS_MANAGER help Support for using PCI devices with VFIO. -if VFIO_PCI_CORE config VFIO_PCI_MMAP def_bool y if !S390
@@ -17,6 +15,7 @@ config VFIO_PCI_INTX config VFIO_PCI tristate "Generic VFIO support for any PCI device" + select VFIO_PCI_CORE help Support for the generic PCI VFIO bus driver which can connect any PCI device to the VFIO framework.
@@ -50,6 +49,7 @@ endif config MLX5_VFIO_PCI tristate "VFIO support for MLX5 PCI devices" depends on MLX5_CORE + select VFIO_PCI_CORE help This provides a PCI support for MLX5 devices using the VFIO framework. The device specific driver supports suspend/resume