Thread (4 messages) 4 messages, 2 authors, 2021-07-25

Re: [RESEND] admin-guide/cputopology.rst: Remove non-existed cpu-hotplug.txt

From: "xuyang2018.jy@fujitsu.com" <xuyang2018.jy@fujitsu.com>
Date: 2021-07-13 01:26:50

on 2021/7/13 0:16, Jonathan Corbet wrote:
Yang Xu[off-list ref]  writes:
quoted
Since kernel commit ff58fa7f556c ("Documentation: Update CPU hotplug and move it to core-api"),
cpu_hotplug.txt has been removed. We should update it in here.

Signed-off-by: Yang Xu<xuyang2018.jy@fujitsu.com>
---
  Documentation/admin-guide/cputopology.rst | 10 +++++-----
  1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/Documentation/admin-guide/cputopology.rst b/Documentation/admin-guide/cputopology.rst
index b90dafcc8237..cc28b1a16371 100644
--- a/Documentation/admin-guide/cputopology.rst
+++ b/Documentation/admin-guide/cputopology.rst
@@ -135,9 +135,9 @@ source for the output is in brackets ("[]").
  		[NR_CPUS-1]

      offline:	CPUs that are not online because they have been
-		HOTPLUGGED off (see cpu-hotplug.txt) or exceed the limit
-		of CPUs allowed by the kernel configuration (kernel_max
-		above). [~cpu_online_mask + cpus>= NR_CPUS]
+		HOTPLUGGED off or exceed the limit of CPUs allowed by the
+		kernel configuration (kernel_max above).
+		[~cpu_online_mask + cpus>= NR_CPUS]
Is there a reason why you took out the reference to cpu-hotplug.txt
entirely rather than switching it to the rst file?
Because rst file doesn't have HOTPLUGGED off information and
ABI/testing/sysfs-devices-system-cpu file for offline  also doesn't have
cpu-hotplug.txt or rst file.

So I think removing it is better.

Best Regards
Yang Xu
Thanks,

jon
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help