Re: [PATCH 2/7] mm: introduce pte_install() helper
From: Kirill A. Shutemov <hidden>
Date: 2021-07-18 21:31:22
Also in:
linux-mm, lkml
From: Kirill A. Shutemov <hidden>
Date: 2021-07-18 21:31:22
Also in:
linux-mm, lkml
On Sun, Jul 18, 2021 at 12:30:28PM +0800, Qi Zheng wrote:
Currently we have three times the same few lines repeated in the code. Deduplicate them by newly introduced pte_install() helper. Signed-off-by: Qi Zheng <redacted>
I don't like the name of the helper: we have confusion of PTE being PTE-entry or PTE page table. And pte_install() doing pmd_populate() doesn't help the situation. Maybe pmd_install()? Or pte_table_install()? I donno. -- Kirill A. Shutemov