Thread (72 messages) 72 messages, 9 authors, 2021-08-05

RE: [PATCH 01/14] x86/cpu: Move intel-family to arch-independent headers

From: "Luck, Tony" <tony.luck@intel.com>
Date: 2021-07-15 18:30:00
Also in: linux-arm-kernel, linux-aspeed, linux-devicetree, linux-hwmon, lkml, openbmc

Having 2 potential places for the same definition causes a small
ongoing maintenance / review burden, so I vote moving the file rather
than leaving a place holder, but it's ultimately an x86 maintainer
call.
I thought the patch kept the old file as a stub with just one line:

#include <linux/x86/intel-family.h>

to grab the real data from the new location.  So the information isn't
in two places.

$ git grep -l asm/intel-family.h | wc -l
53

Dang. We seem to love spraying model specific code all over the place :-(

My opinion is to post as Iwona wrote it ... but be prepared for the maintainers
to say "It's only 53 files ... just fix them all"

-Tony
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help