Re: [PATCH 08/10] vfio/mtty: Convert to use vfio_register_group_dev()
From: Kirti Wankhede <kwankhede@nvidia.com>
Date: 2021-06-16 20:21:08
Also in:
dri-devel, intel-gfx, kvm, linux-s390
-static int mtty_reset(struct mdev_device *mdev) +static int mtty_reset(struct mdev_state *mdev_stte)
Nit pick: s/mdev_stte/mdev_state
+static const struct vfio_device_ops mtty_dev_ops = {
+ .name = "vfio-mdev",I think name should be different that 'vfio-mdev', probably 'vfio-mdev-mtty' or 'vfio-mtty' Rest looks fine to me. Reviewed-by: Kirti Wankhede <kwankhede@nvidia.com>