Re: [PATCH 08/10] vfio/mtty: Convert to use vfio_register_group_dev()

Allow mdev drivers to directly create the vfio_device (v3) · Christoph Hellwig <hch@lst.de> · 2021-06-15
[PATCH 01/10] driver core: Pull required checks into driver_probe_device() · Christoph Hellwig <hch@lst.de> · 2021-06-15
[PATCH 02/10] driver core: Better distinguish probe errors in really_probe · Christoph Hellwig <hch@lst.de> · 2021-06-15
Re: [PATCH 02/10] driver core: Better distinguish probe errors in really_probe · Cornelia Huck <cohuck@redhat.com> · 2021-06-15
Re: [PATCH 02/10] driver core: Better distinguish probe errors in really_probe · Greg Kroah-Hartman <gregkh@linuxfoundation.org> · 2021-06-15
Re: [PATCH 02/10] driver core: Better distinguish probe errors in really_probe · Greg Kroah-Hartman <gregkh@linuxfoundation.org> · 2021-06-15
Re: [PATCH 02/10] driver core: Better distinguish probe errors in really_probe · Kirti Wankhede <kwankhede@nvidia.com> · 2021-06-16
[PATCH 03/10] driver core: Flow the return code from ->probe() through to sysfs bind · Christoph Hellwig <hch@lst.de> · 2021-06-15
[PATCH 04/10] driver core: Don't return EPROBE_DEFER to userspace during sysfs bind · Christoph Hellwig <hch@lst.de> · 2021-06-15
Re: [PATCH 04/10] driver core: Don't return EPROBE_DEFER to userspace during sysfs bind · Cornelia Huck <cohuck@redhat.com> · 2021-06-15
Re: [PATCH 04/10] driver core: Don't return EPROBE_DEFER to userspace during sysfs bind · Alex Williamson <hidden> · 2021-06-15
[PATCH 05/10] driver core: Export device_driver_attach() · Christoph Hellwig <hch@lst.de> · 2021-06-15
Re: [PATCH 05/10] driver core: Export device_driver_attach() · Greg Kroah-Hartman <gregkh@linuxfoundation.org> · 2021-06-15
[PATCH 06/10] vfio/mdev: Remove CONFIG_VFIO_MDEV_DEVICE · Christoph Hellwig <hch@lst.de> · 2021-06-15
Re: [PATCH 06/10] vfio/mdev: Remove CONFIG_VFIO_MDEV_DEVICE · Greg Kroah-Hartman <gregkh@linuxfoundation.org> · 2021-06-15
Re: [PATCH 06/10] vfio/mdev: Remove CONFIG_VFIO_MDEV_DEVICE · Kirti Wankhede <kwankhede@nvidia.com> · 2021-06-16
[PATCH 07/10] vfio/mdev: Allow the mdev_parent_ops to specify the device driver to bind · Christoph Hellwig <hch@lst.de> · 2021-06-15
Re: [PATCH 07/10] vfio/mdev: Allow the mdev_parent_ops to specify the device driver to bind · Cornelia Huck <cohuck@redhat.com> · 2021-06-15
Re: [PATCH 07/10] vfio/mdev: Allow the mdev_parent_ops to specify the device driver to bind · Greg Kroah-Hartman <gregkh@linuxfoundation.org> · 2021-06-15
Re: [PATCH 07/10] vfio/mdev: Allow the mdev_parent_ops to specify the device driver to bind · Jason Gunthorpe <jgg@nvidia.com> · 2021-06-16
Re: [PATCH 07/10] vfio/mdev: Allow the mdev_parent_ops to specify the device driver to bind · Greg Kroah-Hartman <gregkh@linuxfoundation.org> · 2021-06-16
Re: [PATCH 07/10] vfio/mdev: Allow the mdev_parent_ops to specify the device driver to bind · Kirti Wankhede <kwankhede@nvidia.com> · 2021-06-16
[PATCH 08/10] vfio/mtty: Convert to use vfio_register_group_dev() · Christoph Hellwig <hch@lst.de> · 2021-06-15
Re: [PATCH 08/10] vfio/mtty: Convert to use vfio_register_group_dev() · Greg Kroah-Hartman <gregkh@linuxfoundation.org> · 2021-06-15
Re: [PATCH 08/10] vfio/mtty: Convert to use vfio_register_group_dev() · Kirti Wankhede <kwankhede@nvidia.com> · 2021-06-16
[PATCH 09/10] vfio/mdpy: Convert to use vfio_register_group_dev() · Christoph Hellwig <hch@lst.de> · 2021-06-15
Re: [PATCH 09/10] vfio/mdpy: Convert to use vfio_register_group_dev() · Greg Kroah-Hartman <gregkh@linuxfoundation.org> · 2021-06-15
[PATCH 10/10] vfio/mbochs: Convert to use vfio_register_group_dev() · Christoph Hellwig <hch@lst.de> · 2021-06-15
Re: [PATCH 10/10] vfio/mbochs: Convert to use vfio_register_group_dev() · Greg Kroah-Hartman <gregkh@linuxfoundation.org> · 2021-06-15
Re: Allow mdev drivers to directly create the vfio_device (v3) · Alex Williamson <hidden> · 2021-06-15
Re: Allow mdev drivers to directly create the vfio_device (v3) · Jason Gunthorpe <jgg@nvidia.com> · 2021-06-15
Re: Allow mdev drivers to directly create the vfio_device (v3) · Christoph Hellwig <hch@lst.de> · 2021-06-16
Re: Allow mdev drivers to directly create the vfio_device (v3) · Jason Gunthorpe <jgg@nvidia.com> · 2021-06-16

From: Kirti Wankhede <kwankhede@nvidia.com>
Date: 2021-06-16 20:21:08
Also in: dri-devel, intel-gfx, kvm, linux-s390

-static int mtty_reset(struct mdev_device *mdev)
+static int mtty_reset(struct mdev_state *mdev_stte)

Nit pick:
s/mdev_stte/mdev_state

  
+static const struct vfio_device_ops mtty_dev_ops = {
+	.name = "vfio-mdev",

I think name should be different that 'vfio-mdev', probably
'vfio-mdev-mtty' or 'vfio-mtty'

Rest looks fine to me.

Reviewed-by: Kirti Wankhede <kwankhede@nvidia.com>

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help