Thread (10 messages) 10 messages, 4 authors, 2021-06-16

Re: [PATCH 1/3] docs: block/bfq: describe per-device weight

From: Kirill Kolyshkin <hidden>
Date: 2021-06-14 21:04:49
Also in: cgroups

On Sun, Jun 13, 2021 at 4:14 PM Jonathan Corbet [off-list ref] wrote:
Kir Kolyshkin [off-list ref] writes:

This work looks generally good, but...
quoted
The functionality of setting per-device weight for BFQ was added
in v5.4 (commit 795fe54c2a828099), but the documentation was never
updated.

While at it, improve formatting a bit.

Signed-off-by: Kir Kolyshkin <redacted>
---
 Documentation/block/bfq-iosched.rst | 38 ++++++++++++++++++++---------
 1 file changed, 27 insertions(+), 11 deletions(-)
diff --git a/Documentation/block/bfq-iosched.rst b/Documentation/block/bfq-iosched.rst
index 66c5a4e54130..7200152c461e 100644
--- a/Documentation/block/bfq-iosched.rst
+++ b/Documentation/block/bfq-iosched.rst
@@ -553,20 +553,36 @@ throughput sustainable with bfq, because updating the blkio.bfq.*
 stats is rather costly, especially for some of the stats enabled by
 CONFIG_BFQ_CGROUP_DEBUG.

-Parameters to set
------------------
+Parameters
+----------

-For each group, there is only the following parameter to set.
+For each group, the following parameters cat be set:
Could we please not introduce new typos while fixing other stuff?
Are you a dog person? :)

Thanks for catching this, corrected patch sent.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help