Re: [PATCH 09/14] d_path: introduce struct prepend_buffer
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2021-06-28 17:10:40
Also in:
linux-fsdevel, linux-s390, lkml
On Mon, Jun 28, 2021 at 06:42:48PM +0200, Enrico Weigelt, metux IT consult wrote:
quoted
quoted
this smells like a generic enough thing to go into lib, doesn't it ?Maybe, but the struct prepend_buffer also needs to be moved into lib. Is it necessary? Is there any other user of struct prepend_buffer?Don't have a specific use case right now, but it smells like a pretty generic string function. Is already having more than one user a hard requirement for putting something into lib ?
Why it should be in the lib/? Do we have users of the same functionality already? The rule of thumb is to avoid generalization without need. -- With Best Regards, Andy Shevchenko