Re: [PATCH v9] pgo: add clang's Profile Guided Optimization infrastructure

On Sat, Jun 12, 2021 at 1:56 PM Bill Wendling [off-list ref] wrote:

On Sat, Jun 12, 2021 at 1:25 PM Peter Zijlstra [off-list ref] wrote:

quoted

On Sat, Jun 12, 2021 at 12:10:03PM -0700, Bill Wendling wrote:
Yes it is, but is that sufficient in this case? It very much isn't for
KASAN, UBSAN, and a whole host of other instrumentation crud. They all
needed their own 'bugger-off' attributes.

Now, for the "nointr" issue. I'll see if we need an additional change for that.

The GCOV implementation disables profiling in those directories where
instrumentation would fail. We do the same. Both clang and gcc seem to
treat the no_instrument_function attribute similarly.

-bw