Re: [PATCH v7 1/4] PCI: Introduce pcim_alloc_irq_vectors()

On Mon, Jun 07, 2021 at 07:12:34PM +0300, Andy Shevchenko wrote:

On Mon, Jun 07, 2021 at 11:39:13PM +0800, Dejin Zheng wrote:

quoted

Introduce pcim_alloc_irq_vectors(), a device-managed version of
pci_alloc_irq_vectors(). Introducing this function can simplify
the error handling path in many drivers.

And use pci_free_irq_vectors() to replace some code in pcim_release(),
they are equivalent, and no functional change. It is more explicit
that pcim_alloc_irq_vectors() is a device-managed function.

...

quoted

When CONFIG_PCI=n, there is no stub for pci_is_managed(), but
pcim_alloc_irq_vectors() will use it, so add one like other similar stubs.
Otherwise there can be build errors, as here by kernel test robot
reported:
include/linux/pci.h: In function 'pcim_alloc_irq_vectors':

quoted

quoted

include/linux/pci.h:1847:7: error: implicit declaration of function 'pci_is_managed' [-Werror=implicit-function-declaration]

    1847 |  if (!pci_is_managed(dev))
         |       ^~~~~~~~~~~~~~

This is rather changelog related material. No need to pollute commit message
with this.

...

quoted

Reported-by: kernel test robot <redacted>

It's new functionality. Why this tag is here?
Use comments (similar location than changelog) to give a credit if you wish.

Agreed, I'll tidy that up, so no need to repost for this.