Thread (50 messages) 50 messages, 4 authors, 2021-06-15

Re: [PATCH V3 4/9] tracing/hwlat: Implement the per-cpu mode

From: Daniel Bristot de Oliveira <hidden>
Date: 2021-06-04 15:31:17
Also in: lkml

On 6/3/21 11:17 PM, Steven Rostedt wrote:
On Fri, 14 May 2021 22:51:13 +0200
Daniel Bristot de Oliveira [off-list ref] wrote:
quoted
 void trace_hwlat_callback(bool enter)
 {
-	if (smp_processor_id() != nmi_cpu)
+	struct hwlat_kthread_data *kdata = get_cpu_data();
+
+	if (kdata->kthread)
Shouldn't that be:

	if (!kdata->kthread)
oops! Fixing in v4.

-- Daniel

?

-- Steve
quoted
 		return;
 
 	/*
@@ -158,13 +173,13 @@ void trace_hwlat_callback(bool enter)
 	 */
 	if (!IS_ENABLED(CONFIG_GENERIC_SCHED_CLOCK)) {
 		if (enter)
-			nmi_ts_start = time_get();
+			kdata->nmi_ts_start = time_get();
 		else
-			nmi_total_ts += time_get() - nmi_ts_start;
+			kdata->nmi_total_ts += time_get() - kdata->nmi_ts_start;
 	}
 
 	if (enter)
-		nmi_count++;
+		kdata->nmi_count++;
 }
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help