Re: [PATCH v4 3/5] hwmon: (pmbus/pim4328) Allow phase function even if it's not on page
From: Guenter Roeck <linux@roeck-us.net>
Date: 2021-06-02 12:10:38
Also in:
linux-hwmon, lkml
On Tue, Jun 01, 2021 at 06:43:18PM +0200, Erik Rosen wrote:
Allow the use of a phase function even if it does not exist not on the associated page.
Nit: Too many "not" Otherwise, for my reference: Reviewed-by: Guenter Roeck <linux@roeck-us.net> Guenter
quoted hunk ↗ jump to hunk
Signed-off-by: Erik Rosen <redacted> --- drivers/hwmon/pmbus/pmbus_core.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c index cd80cb574267..7c4f7b6c846e 100644 --- a/drivers/hwmon/pmbus/pmbus_core.c +++ b/drivers/hwmon/pmbus/pmbus_core.c@@ -1327,14 +1327,14 @@ static int pmbus_add_sensor_attrs(struct i2c_client *client, pages = paged ? info->pages : 1; for (page = 0; page < pages; page++) { - if (!(info->func[page] & attrs->func)) - continue; - ret = pmbus_add_sensor_attrs_one(client, data, info, - name, index, page, - 0xff, attrs, paged); - if (ret) - return ret; - index++; + if (info->func[page] & attrs->func) { + ret = pmbus_add_sensor_attrs_one(client, data, info, + name, index, page, + 0xff, attrs, paged); + if (ret) + return ret; + index++; + } if (info->phases[page]) { int phase;-- 2.20.1