Thread (10 messages) 10 messages, 3 authors, 2021-05-21

Re: [PATCH v2 00/17] Adding support for controlling the leds found on Intel NUC

From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Date: 2021-05-19 12:15:17
Also in: linux-leds, lkml

Em Wed, 19 May 2021 13:11:07 +0200
Pavel Machek [off-list ref] escreveu:
Hi!
quoted
Some models come with single colored or dual-colored LEDs, but high end models 
have RGB LEDs.

Programming them can ether be done via BIOS or by the OS, however, BIOS settings
are limited. So, the vendor offers a Windows application that allows to fully use the
functionality provided by the firmware/hardware.  
I'm not sure why you are submitting v2 in the middle of interface
discussion.
I'll refrain sending a new version while we're discussing the interface.
Marek and I are saying the same thing -- this needs to use close to
existing APIs.
Ok, but I'm not seeing an existing API that provides what those
LEDs need.
If you want to get something merged quickly, please submit basic
functionality only (toggling the LED on/off) that completely fits
existing APIs. We can review that.
If you prefer working this way, I can send an initial patch with
just the very basic. Actually, if you apply just patch 2 of this
series, it will provide support for for just setting the brightness
on NUC8.

However, the main reason why someone (including myself) want this
driver is to allow to dynamically change what hardware event will
be triggering the LED and how, and if suspend will blink or not[1].

Being able to also change the LED color is a plus.

[1] Disabling blink at suspend/hibernate is one of the things that
I use here: as the machine is at my bedroom, I don't want it to be
blinking all night long when the machine is sleeping :-)

Thanks,
Mauro
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help