Thread (9 messages) 9 messages, 3 authors, 2021-04-30

Re: [PATCH 2/4] lib/vsprintf.c: Make %p{D,d} mean as much components as possible

From: Andy Shevchenko <hidden>
Date: 2021-04-28 15:10:39
Also in: linux-s390, linux-wireless, lkml, netdev

On Wed, Apr 28, 2021 at 5:56 PM Jia He [off-list ref] wrote:
From: Linus Torvalds <torvalds@linux-foundation.org>
Hmm... Okay.
We have '%pD'(no digit following) for printing a filename. It may not be
perfect (by default it only prints one component.

%pD4 should be more than good enough, but we should make plain "%pD" mean
"as much of the path that is reasonable" rather than "as few components as
possible" (ie 1).
Sorry, but from above I didn't get why.

The commit message tells only about %pD, but patch changes behaviour
of the ~100 or so users of "%pd" without any explanation.

Besides that the patch is prepended only by one change (which is also
not related to %pD), while we have ~30 users which behaviour got
changed.


-- 
With Best Regards,
Andy Shevchenko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help