Re: [PATCH v2 1/4] dt-bindings: mfd: Add bindings for Ampere Altra SMPro drivers
From: Rob Herring <robh@kernel.org>
Date: 2021-03-30 21:16:27
Also in:
linux-aspeed, linux-devicetree, linux-hwmon, lkml, openbmc
On Mon, Mar 29, 2021 at 08:52:35AM +0700, Quan Nguyen wrote:
quoted hunk ↗ jump to hunk
Adds device tree bindings for SMPro drivers found on the Mt.Jade hardware reference platform with Ampere's Altra Processor family. Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com> --- .../bindings/hwmon/ampere,ac01-hwmon.yaml | 27 ++++++ .../devicetree/bindings/mfd/ampere,smpro.yaml | 82 +++++++++++++++++++ 2 files changed, 109 insertions(+) create mode 100644 Documentation/devicetree/bindings/hwmon/ampere,ac01-hwmon.yaml create mode 100644 Documentation/devicetree/bindings/mfd/ampere,smpro.yamldiff --git a/Documentation/devicetree/bindings/hwmon/ampere,ac01-hwmon.yaml b/Documentation/devicetree/bindings/hwmon/ampere,ac01-hwmon.yaml new file mode 100644 index 000000000000..015130a281f4 --- /dev/null +++ b/Documentation/devicetree/bindings/hwmon/ampere,ac01-hwmon.yaml@@ -0,0 +1,27 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/hwmon/ampere,ac01-hwmon.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Hardware monitoring driver for the Ampere Altra SMPro + +maintainers: + - Quan Nguyen <quan@os.amperecomputing.com> + +description: | + This module is part of the Ampere Altra SMPro multi-function device. For more + details see ../mfd/ampere,smpro.yaml. + +properties: + compatible: + enum: + - ampere,ac01-hwmon + + reg: + maxItems: 1 + +required: + - compatible + +additionalProperties: falsediff --git a/Documentation/devicetree/bindings/mfd/ampere,smpro.yaml b/Documentation/devicetree/bindings/mfd/ampere,smpro.yaml new file mode 100644 index 000000000000..bf789c8a3d7d --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/ampere,smpro.yaml@@ -0,0 +1,82 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/ampere,smpro.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Ampere Altra SMPro firmware driver + +maintainers: + - Quan Nguyen <quan@os.amperecomputing.com> + +description: | + Ampere Altra SMPro firmware may contain different blocks like hardware + monitoring, error monitoring and other miscellaneous features. + +properties: + compatible: + const: ampere,smpro
Only 1 version of SMPro? Needs to be more specific or provide details on how the exact version of firmware/hardware is discovered.
+ + reg: + description: + I2C device address. + maxItems: 1 + + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + +patternProperties: + "^hwmon(@[0-9a-f]+)?$": + $ref: ../hwmon/ampere,ac01-hwmon.yaml + + "^misc(@[0-9a-f]+)?$": + type: object + description: Ampere Altra SMPro Misc driver
Bindings describe h/w, not drivers.
+ properties:
+ compatible:
+ const: "ampere,ac01-misc"
+
+ "^errmon(@[0-9a-f]+)?$":
+ type: object
+ description: Ampere Altra SMPro Error Monitor driver
+ properties:
+ compatible:
+ const: "ampere,ac01-errmon"
+
+required:
+ - "#address-cells"
+ - "#size-cells"
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ smpro@4f {
+ compatible = "ampere,smpro";
+ reg = <0x4f>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ hwmon {
+ compatible = "ampere,ac01-hwmon";
+ };
+
+ misc {
+ compatible = "ampere,ac01-misc";
+ };
+
+ errmon {
+ compatible = "ampere,ac01-errmon";
+ };None of the child nodes have any resources in DT, so you don't need them in DT. Rob