Re: [PATCH v5 02/11] configfs: use (1UL << bit) for internal flags

[PATCH v5 00/11] gpio: implement the configfs testing module · Bartosz Golaszewski <hidden> · 2021-03-15
[PATCH v5 01/11] configfs: increase the item name length · Bartosz Golaszewski <hidden> · 2021-03-15
[PATCH v5 02/11] configfs: use (1UL << bit) for internal flags · Bartosz Golaszewski <hidden> · 2021-03-15
RE: [PATCH v5 02/11] configfs: use (1UL << bit) for internal flags · David Laight <hidden> · 2021-03-15
Re: [PATCH v5 02/11] configfs: use (1UL << bit) for internal flags · Andy Shevchenko <hidden> · 2021-03-15
[PATCH v5 05/11] lib: bitmap: remove the 'extern' keyword from function declarations · Bartosz Golaszewski <hidden> · 2021-03-15
[PATCH v5 04/11] samples: configfs: add a committable group · Bartosz Golaszewski <hidden> · 2021-03-15
[PATCH v5 03/11] configfs: implement committable items · Bartosz Golaszewski <hidden> · 2021-03-15
[PATCH v5 06/11] lib: bitmap: order includes alphabetically · Bartosz Golaszewski <hidden> · 2021-03-15
[PATCH v5 07/11] lib: bitmap: provide devm_bitmap_alloc() and devm_bitmap_zalloc() · Bartosz Golaszewski <hidden> · 2021-03-15
[PATCH v5 10/11] selftests: gpio: add a helper for reading GPIO line names · Bartosz Golaszewski <hidden> · 2021-03-15
[PATCH v5 08/11] gpio: sim: new testing module · Bartosz Golaszewski <hidden> · 2021-03-15
[PATCH v5 09/11] selftests: gpio: provide a helper for reading chip info · Bartosz Golaszewski <hidden> · 2021-03-15
[PATCH v5 11/11] selftests: gpio: add test cases for gpio-sim · Bartosz Golaszewski <hidden> · 2021-03-15
Re: [PATCH v5 00/11] gpio: implement the configfs testing module · Bartosz Golaszewski <hidden> · 2021-03-22
Re: [PATCH v5 00/11] gpio: implement the configfs testing module · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-03-23
Re: [PATCH v5 00/11] gpio: implement the configfs testing module · Linus Walleij <hidden> · 2021-03-25
Re: [PATCH v5 00/11] gpio: implement the configfs testing module · Bartosz Golaszewski <hidden> · 2021-03-26

From: Andy Shevchenko <hidden>
Date: 2021-03-15 16:37:55
Also in: linux-gpio, lkml

On Mon, Mar 15, 2021 at 5:33 PM David Laight [off-list ref] wrote:

From: Bartosz Golaszewski

quoted

Sent: 15 March 2021 09:14

From: Bartosz Golaszewski <redacted>

For better readability and maintenance: use the (1UL << bit) for flag
definitions.

If the values ever get printed in hex the hex definitions are
actually more useful.

Huh?!


-- 
With Best Regards,
Andy Shevchenko

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help