Thread (18 messages) 18 messages, 4 authors, 2021-03-12

Re: [PATCH v3 08/11] gpio: sim: new testing module

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2021-03-12 11:05:03
Also in: linux-gpio, lkml

On Fri, Mar 12, 2021 at 09:54:58AM +0100, Bartosz Golaszewski wrote:
On Wed, Mar 10, 2021 at 1:28 PM Andy Shevchenko
[off-list ref] wrote:
...
quoted
quoted
+             ret = sprintf(page, "n/a\n");
I dunno '/' (slash) is a good character to be handled in a shell.
I would prefer 'none' or 'not available' (I think space is easier,
because the rules to escape much simpler: need just to take it into
quotes, while / needs to be escaped separately).
My test cases work fine with 'n/a' but I can change it to 'none' if
it's less controversial.

% git grep -n -w '"none"' -- drivers/ arch/ | wc -l
371

% git grep -n -w '"n/a"' -- drivers/ arch/ | wc -l
15

% git grep -n -w '"not available"' -- drivers/ arch/ | wc -l
5

...
But I would be creating empty properties for nothing. Better to just
not have them at all.
Up to you.

-- 
With Best Regards,
Andy Shevchenko

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help