On Mon, Mar 8, 2021 at 4:32 PM Andy Shevchenko
[off-list ref] wrote:

On Mon, Mar 08, 2021 at 04:13:33PM +0100, Bartosz Golaszewski wrote:

quoted

On Mon, Mar 8, 2021 at 4:05 PM Andy Shevchenko
[off-list ref] wrote:

quoted

On Mon, Mar 08, 2021 at 03:23:31PM +0100, Bartosz Golaszewski wrote:

...

quoted

quoted

I have strong opinion not to open code "yet another parser".

So, grepping on 'strsep(.*, ",")' shows a lot of code that wants something like
this. Interesting are the net/9p cases. This in particular pointed out to
lib/parser.c which in turn shows promising match_strlcpy() / match_strdup(). I
haven't looked deeply though.

That said, I agree that next_arg() is not the best here.

Shall we revisit this once it's upstream with a generalization for
separating comma separated strings?

How can we guarantee it won't be forgotten?

I will add a REVISIT comment, so *obviously* it ***will*** be revisited. :)

Bartosz