Re: [RFT PATCH v3 10/27] docs: driver-api: device-io: Document ioremap() variants & access funcs

From
Arnd Bergmann <arnd@kernel.org>
Date
2021-03-05 15:52:20
Also in
linux-arch, linux-arm-kernel, linux-devicetree, linux-samsung-soc, linux-serial, lkml
Reply to
Andy Shevchenko, 2021-03-05
On Fri, Mar 5, 2021 at 4:09 PM Andy Shevchenko
[off-list ref] wrote:
On Fri, Mar 5, 2021 at 12:25 PM Linus Walleij [off-list ref] wrote:
quoted
On Thu, Mar 4, 2021 at 10:40 PM Hector Martin [off-list ref] wrote:
quoted
This documents the newly introduced ioremap_np() along with all the
other common ioremap() variants, and some higher-level abstractions
available.

Signed-off-by: Hector Martin <redacted>
I like this, I just want one change:

Put the common ioremap() on top in all paragraphs, so the norm
comes before the exceptions.

I.e. it is weird to mention ioremap_np() before mentioning ioremap().
+1 here. That is what I have stumbled upon reading carefully.
In that case, the order should probably be:

ioremap
ioremap_wc
ioremap_wt
ioremap_np
ioremap_uc
ioremap_cache

Going from most common to least common, rather than going from
strongest to weakest.

       Arnd
Thread (134 messages) 134 messages, 10 authors, last reply 2021-04-01
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help