Re: [PATCH 5/7] printk: Make %pS and friends print module build ID

On Mon, Mar 01, 2021 at 09:43:19PM -0500, Steven Rostedt wrote:

On Mon,  1 Mar 2021 09:47:47 -0800
Stephen Boyd [off-list ref] wrote:

quoted

The %pS printk format (among some others) is used to print kernel
addresses symbolically. When the kernel prints an address inside of a
module, the kernel prints the addresses' symbol name along with the
module's name that contains the address. Let's make kernel stacktraces
easier to identify on KALLSYMS builds by including the build ID of a
module when we print the address.

Please no!

This kills the output of tracing with offset, and can possibly break
scripts. I don't want to look at traces like this!

          <idle>-0       [004] ..s1   353.842577: ipv4_conntrack_in+0x0/0x10 [nf_conntrack] (3b39eb771b2566331887f671c741f90bfba0b051) <-nf_hook_slow+0x40/0xb0

Would it make sense to only print the build-id if it differs from the
build-id of the kernel which has loaded it?