Thread (18 messages) 18 messages, 4 authors, 2021-02-19

Re: [PATCH v3 2/4] Documentation: devres: Add pcim_alloc_irq_vectors()

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2021-02-17 13:46:55
Also in: linux-i2c, linux-pci, lkml

On Wed, Feb 17, 2021 at 06:50:04PM +0800, Dejin Zheng wrote:
On Tue, Feb 16, 2021 at 06:10:52PM +0100, Krzysztof Wilczyński wrote:
...
quoted
Having said that, people might ask - how does it simplify the error
handling path?

You might have to back this with a line of two to explain how does the
change achieved that, so that when someone looks at the commit message
it would be clear what the benefits of the change were.
The device-managed function is a conventional concept that every developer
knows. So don't worry about this. And I really can't explain its operation
mechanism to you in a sentence or two. If you are really interested, you
can read the relevant code.
I tend on agree on the above. It would be enough to spell it clearly that it's
part of devres API (Managed Device Resource) and we are fine.

-- 
With Best Regards,
Andy Shevchenko

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help