Re: [PATCH v5 1/6] misc: Add Synopsys DesignWare xData IP driver

On Thu, Feb 11, 2021 at 03:02:03PM +0100, Greg Kroah-Hartman wrote:

On Thu, Feb 11, 2021 at 03:50:19PM +0200, Leon Romanovsky wrote:

quoted

On Thu, Feb 11, 2021 at 01:32:13PM +0100, Greg Kroah-Hartman wrote:

quoted

On Thu, Feb 11, 2021 at 01:42:43PM +0200, Leon Romanovsky wrote:

quoted

On Thu, Feb 11, 2021 at 10:08:38AM +0100, Gustavo Pimentel wrote:

quoted

Add Synopsys DesignWare xData IP driver. This driver enables/disables
the PCI traffic generator module pertain to the Synopsys DesignWare
prototype.

Signed-off-by: Gustavo Pimentel <redacted>
---
 drivers/misc/dw-xdata-pcie.c | 394 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 394 insertions(+)
 create mode 100644 drivers/misc/dw-xdata-pcie.c

<...>

quoted

+MODULE_LICENSE("GPL v2");

"GPL" and not "GPL v2".

There is no difference, please go read module.h.

I read and this is why I said it.
Documentation/process/license-rules.rst: "It exists for historic reasons."

Historic, for me, means that new code is better do not use this.

Nope, either is fine for new code, author gets to pick what they want.
Personally, I like the explicitness of "GPL v2" for a variety of
reasons.

Feel free to update the documentation.

Personally, I don't like two names for the same license. This is one of
the reasons why SPFX clearly marks the code license, It is why we have
"SPDX-License-Identifier: GPL-2.0" and not "SPDX-License-Identifier: GPL".

https://spdx.org/licenses/preview/
GNU General Public License v2.0 only 	        GPL-2.0-only
GNU General Public License v2.0 or later 	GPL-2.0-or-later

Thanks

thanks,

greg k-h