Re: [PATCH v3 net-next 1/1] Allow user to set metric on default route learned via Router Advertisement.
From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-01-23 20:02:33
Also in:
lkml, netdev
Possibly related (same subject, not in this thread)
- 2021-01-22 · Re: [PATCH v3 net-next 1/1] Allow user to set metric on default route learned via Router Advertisement. · David Ahern <hidden>
- 2021-01-19 · [PATCH v3 net-next 1/1] Allow user to set metric on default route learned via Router Advertisement. · Praveen Chaudhary <hidden>
On Fri, 22 Jan 2021 22:16:41 -0700 David Ahern wrote:
On 1/22/21 9:02 PM, Maciej Żenczykowski wrote:quoted
Why can't we get rid of the special case for 0 and simply make 1024 the default value?That would work too.
Should we drop it then? Easier to bring it back than to change the interpretation later. It doesn't seem to serve any clear purpose right now. (Praveen if you post v4 please take a look at the checkpatch --strict warnings and address the ones which make sense, e.g. drop the brackets around comparisons, those are just noise, basic grasp of C operator precedence can be assumed in readers of kernel code).